Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify test_mempool_performance.py #16644

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Simplify test_mempool_performance.py #16644

merged 1 commit into from
Oct 25, 2023

Conversation

AmineKhaldi
Copy link
Contributor

  • Remove flake8 exclusions.
  • Cleanup imports.
  • Remove unused logger.
  • Simplify helper functions.
  • Remove unneeded test class.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Oct 17, 2023
@AmineKhaldi AmineKhaldi self-assigned this Oct 17, 2023
@AmineKhaldi AmineKhaldi force-pushed the simplify_test_mempool_performance branch from 5a15f82 to 5684d9f Compare October 17, 2023 16:38
@coveralls-official
Copy link

coveralls-official bot commented Oct 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6613206535

  • 4 of 32 (12.5%) changed or added relevant lines in 1 file are covered.
  • 99 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.08%) to 90.086%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/core/mempool/test_mempool_performance.py 4 32 12.5%
Files with Coverage Reduction New Missed Lines %
chia/harvester/harvester_api.py 1 73.02%
chia/full_node/full_node.py 2 85.91%
chia/timelord/timelord_api.py 2 87.85%
chia/server/node_discovery.py 3 77.84%
chia/server/server.py 6 81.07%
chia/full_node/full_node_api.py 7 77.33%
chia/wallet/wallet_node.py 9 86.99%
chia/timelord/timelord_state.py 20 69.47%
chia/timelord/timelord.py 49 73.85%
Totals Coverage Status
Change from base Build 6592270821: -0.08%
Covered Lines: 93065
Relevant Lines: 103256
💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review October 17, 2023 18:54
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner October 17, 2023 18:54
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 18, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@AmineKhaldi AmineKhaldi force-pushed the simplify_test_mempool_performance branch from 5684d9f to 9bbc2b8 Compare October 19, 2023 11:07
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 19, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@AmineKhaldi
Simplify test_mempool_performance.py.
37bd671 
Remove flake8 exclusions, cleanup imports, simplify helper functions and remove unneeded test class.
@AmineKhaldi AmineKhaldi force-pushed the simplify_test_mempool_performance branch from 9bbc2b8 to 37bd671 Compare October 23, 2023 12:27
@arvidn
Copy link
Contributor

arvidn commented Oct 25, 2023

the missing lines are in benchmarks, so we wouldn't expect them to be instrumented by coverage. There's some issue with our coverage workflow where it fails to add the coverage-diff tag as well as posting the comment

@cmmarslender cmmarslender merged commit e29d71f into Chia-Network:main Oct 25, 2023
This was referenced Oct 28, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmineKhaldi @arvidn @cmmarslender